[GUI Plugin] Action Chains

[capink]

Originally Posted by chaley

@capink: this might have nothing to do with the problem, but this exception can happen if a search reduces the number of books that would be shown in the book list. The "index" is the row number of the book list. The exception is thrown if that row number no longer exists. For example, imagine 30 books being displayed, with book 20 selected. A search reduces the number displayed to 15, moving the selected book to row 10. Even though the current book is still there, the fact that there isn't a book 20 causes the exception to be thrown. If it wasn't thrown then you would most likely have the wrong book.

Also note that if the GUI hasn't been told about a db.search() then it will think that it has current data, which is likely wrong.

Thanks for the help. I think I figured out the problem. I made the wrong assumption that if no row is selected the result of gui.library_view.currentIndex() will evaluate to None and proceeded with:

if gui.library_view.currentIndex():
   ....

Turns out it returns a QModelIndex() that can be test by either:

if gui.library_view.currentIndex().row() >= 0:
   ....

or

if gui.library_view.currentIndex().row() != QModelIndex():
   ....

The selection modifier does not use db.search(). It performs the search directly in calibre GUI:

gui.search.set_search_string(search_string)
gui.search.do_search()

Hope this version fixes the problem.

[chaley]

Originally Posted by capink

Thanks for the help. I think I figured out the problem. I made the wrong assumption that if no row is selected the result of gui.library_view.currentIndex() will evaluate to None and proceeded with:

if gui.library_view.currentIndex():
   ....

[...]

Use

dex = gui.library_view.currentIndex()
if dex.isValid():
    row = dex.row()
    ....

This is easy to test using this python template:

python:
def evaluate(book, context):
	from calibre.gui2.ui import get_gui
	gui = get_gui()
	dex = gui.library_view.currentIndex()
	print(dex, dex.isValid()) 
	return f'row = {dex.row()}' if dex.isValid() else 'Not valid'

To test it, select a book, open the template tester, then paste the template. It will give you a row number. Then search for authors:false (there aren't any books with no authr), which will give an empty list view. Type something in the template tester to make the template run and you will get "Not valid">

[capink]

Thanks

[nqk]

Originally Posted by capink

Thanks

The error has gone.

However, I think the action chain still executes (on which book I don't know) because the indicator shows, but very quickly. It's ok anyway.

[ownedbycats]

Is it possible to give a submenu an icon other than the first chain?

[capink]

Originally Posted by ownedbycats

Is it possible to give a submenu an icon other than the first chain?

No. It is either the first chain icon or no icon at all. You can control this by setting the a plugin tweak to either

action_chains_default_sub_menu_icon = 'first_action'

or

action_chains_default_sub_menu_icon = False

[ownedbycats]

Aside from manually checking all my chains, is there a way to tell if a chain is being used in a caller action prior to rename?

[capink]

Originally Posted by ownedbycats

Aside from manually checking all my chains, is there a way to tell if a chain is being used in a caller action prior to rename?

Attached below is a chain (Run Python Code Action) that gives you two options:

• Print the names of all chains that calls a particular chain (selected from a dropdown menu).
• Rename a chosen chain while also ensuring the new name is reflected in every Chain Caller Action.

Warning: The second option is untested and it might destroy your config. Make sure to make a copy of your "Action Chains.json" file before proceeding. Do this every time you run it.

[chaley]

Originally Posted by ownedbycats

Aside from manually checking all my chains, is there a way to tell if a chain is being used in a caller action prior to rename?

Originally Posted by capink

Warning: The second option is untested and it might destroy your config. Make sure to make a copy of your "Action Chains.json" file before proceeding. Do this every time you run it.

Can't you answer the question while avoiding the risk by editing Action Chains.json with a text editor and searching for the names of interest?

[ownedbycats]

I didn't think of checking the json directly. That should work and be less risky. Thanks both.

[capink]

Originally Posted by chaley

Can't you answer the question while avoiding the risk by editing Action Chains.json with a text editor and searching for the names of interest?

Yes, that would be much simpler. Sometimes you miss simple things in front of you, especially at night after a long day at work.

[chaley]

Originally Posted by capink

Yes, that would be much simpler. Sometimes you miss simple things in front of you, especially at night after a long day at work.

I've done that more times than I can count.

[WordMan]

Some when I lost the Duplicate Plugin icon on the main menu. It appears to install OK but now I have no way of running it. Any ideas? Have uninstalled and reinstalled with no success.

[theducks]

Originally Posted by WordMan

Some when I lost the Duplicate Plugin icon on the main menu. It appears to install OK but now I have no way of running it. Any ideas? Have uninstalled and reinstalled with no success.

Preferences:toolbars:Main toolbar (or any other) Remember there are 2 versions of the toolbar DEVICE Not connected / connected
If the PI is installed correctly: there will be an icon on the left. Use the arrow to move it to the right

[Comfy.n]

Originally Posted by capink

Yes, there has been a change in Calibre6/Qt6 that conflicts the plugin's way of managing icons. I haven't got around to dealing with. But I will sometime in the future.

Hi capink! Is there some update to this issue? I still can't see any custom icons on the menus nor on the chains dialog.